Skip to content

[TOOL-4483] Move changelog to team landing page from notifications #7037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

[TOOL-4483] Move changelog to team landing page from notifications #7037

merged 1 commit into from
May 13, 2025

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented May 13, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on refactoring notification handling, removing unused functions, and introducing a new DismissibleAlert component for better user experience. It streamlines notification management across various components.

Detailed summary

  • Removed getChangelogNotifications from several components.
  • Introduced DismissibleAlert to replace alert handling.
  • Updated NotificationButtonUI to simplify notification management.
  • Adjusted props for various header components to remove unused functions.
  • Enhanced search input placeholder and styling.
  • Modified Changelog component to fetch and display changelog items.
  • Cleaned up cleanupReadNotifications function to handle notifications more efficiently.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented May 13, 2025

TOOL-4483 Add changelog on team landing page

@vercel
Copy link

vercel bot commented May 13, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2025 7:27pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) May 13, 2025 7:27pm
login ⬜️ Skipped (Inspect) May 13, 2025 7:27pm
thirdweb_playground ⬜️ Skipped (Inspect) May 13, 2025 7:27pm
wallet-ui ⬜️ Skipped (Inspect) May 13, 2025 7:27pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 May 13, 2025 13:50 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 13, 2025 13:50 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 13, 2025 13:50 Inactive
@changeset-bot
Copy link

changeset-bot bot commented May 13, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: ab17388

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 13, 2025 13:51 Inactive
@MananTank MananTank marked this pull request as ready for review May 13, 2025 13:51
@MananTank MananTank requested review from a team as code owners May 13, 2025 13:51
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label May 13, 2025
@MananTank Graphite App
Copy link
Member Author

MananTank commented May 13, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented May 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.89%. Comparing base (df06bec) to head (ab17388).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7037   +/-   ##
=======================================
  Coverage   54.89%   54.89%           
=======================================
  Files         909      909           
  Lines       58396    58396           
  Branches     4035     4035           
=======================================
  Hits        32056    32056           
  Misses      26235    26235           
  Partials      105      105
Flag Coverage Δ
packages 54.89% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented May 13, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 54.21 KB (0%) 1.1 s (0%) 201 ms (+159.69% 🔺) 1.3 s
thirdweb (cjs) 193.92 KB (0%) 3.9 s (0%) 350 ms (+21.68% 🔺) 4.3 s
thirdweb (minimal + tree-shaking) 5.68 KB (0%) 114 ms (0%) 92 ms (+1074.86% 🔺) 206 ms
thirdweb/chains (tree-shaking) 524 B (0%) 11 ms (0%) 46 ms (+2653.23% 🔺) 56 ms
thirdweb/react (minimal + tree-shaking) 19.53 KB (0%) 391 ms (0%) 64 ms (+402.87% 🔺) 454 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented May 13, 2025 •
edited
Loading

Merge activity

@MananTank
[TOOL-4483] Move changelog to team landing page from notifications (#…
ab17388 
…7037)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on refactoring notification handling in the application, removing unused functions, and enhancing the UI components related to notifications and alerts.

### Detailed summary
- Removed `getChangelogNotifications` and related props from several components.
- Introduced `DismissibleAlert` component for better alert management.
- Updated `NotificationButtonUI` to streamline notification handling.
- Adjusted UI elements for consistency and clarity.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 13, 2025 19:20 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 13, 2025 19:20 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 13, 2025 19:20 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 13, 2025 19:20 Inactive
@graphite-app graphite-app bot merged commit ab17388 into main May 13, 2025
23 checks passed
@graphite-app graphite-app bot deleted the tool-4483 branch May 13, 2025 20:15
@vercel vercel bot temporarily deployed to Production – login May 13, 2025 20:15 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground May 13, 2025 20:15 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 May 13, 2025 20:15 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui May 13, 2025 20:15 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquim-verges joaquim-verges joaquim-verges approved these changes

Assignees

@MananTank MananTank

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @joaquim-verges